Skip to content

PERF: column_arrays #43278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 11, 2021
Merged

PERF: column_arrays #43278

merged 8 commits into from
Sep 11, 2021

Conversation

jbrockmendel
Copy link
Member

Shaves a couple percent off of time_to_json_wide asv

Reprises #42824.

@jbrockmendel jbrockmendel added IO JSON read_json, to_json, json_normalize Performance Memory or execution speed performance labels Aug 28, 2021
@jreback jreback added this to the 1.4 milestone Aug 30, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

hmm just a couple of percent?

@jreback jreback removed this from the 1.4 milestone Aug 31, 2021
@jbrockmendel
Copy link
Member Author

hmm just a couple of percent?

I'm seeing 13.5% locally

from asv_bench.benchmarks.io.json import *

self = ToJSONWide()
self.setup("columns", "df_td_int_ts")

%timeit self.time_to_json_wide("columns", "df_td_int_ts")
82.4 ms ± 1.71 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- master
71.3 ms ± 1.68 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- PR

@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

just converned this is too specialy casey for json. but not a big deal.

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 1, 2021 via email

@jbrockmendel
Copy link
Member Author

gentle ping; this is the last of the asv-identified perf PRs

@jreback jreback added this to the 1.4 milestone Sep 11, 2021
@jreback jreback merged commit 8519d26 into pandas-dev:master Sep 11, 2021
@jbrockmendel jbrockmendel deleted the perf-column_arrays branch September 11, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO JSON read_json, to_json, json_normalize Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback